incremental delivery without branching#3862
Closed
yaacovCR wants to merge 5 commits intographql:mainfrom
Closed
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yaacovCR
force-pushed
the
squashed
branch
14 times, most recently
from
d8ae014 to
bcfad72
Compare
yaacovCR
force-pushed
the
squashed
branch
12 times, most recently
from
e2e397f to
51fa808
Compare
Contributor
Author
|
I have added a commit to show how deduplication can work. Error boundaries are preserved. In particular: (A) Deduplication For the following operation: query {
a {
b {
c {
d
}
... @defer {
e {
f
}
}
}
}
... @defer {
a {
b {
e {
f
}
}
}
g {
h
}
}
}...the following payloads are generated: [
{
data: {
a: {
b: {
c: {
d: 'd',
},
},
},
},
hasNext: true,
},
{
incremental: [
{
data: {
e: {
f: 'f',
},
},
path: ['a', 'b'],
},
{
data: {
g: {
h: 'h',
},
},
path: [],
},
],
hasNext: false,
},
](B) Null Bubbling is a Deduplication Exception For the following operation: query {
... @defer {
a {
someField
b {
c {
slowNonNullErrorField
}
}
}
}
a {
... @defer {
b {
c {
d
}
}
}
}
}...the following payloads are generated: [
{
data: {
a: {},
},
hasNext: true,
},
{
incremental: [
{
data: {
b: {
c: {
d: 'd',
},
},
},
path: ['a'],
},
],
hasNext: true,
},
{
incremental: [
{
data: {
a: {
b: {
c: null, // <==== note that c is sent as null even though sent already
},
someField: 'someField',
},
},
errors: [
{
message:
'Cannot return null for non-nullable field c.slowNonNullErrorField.',
locations: [{ line: 8, column: 17 }],
path: ['a', 'b', 'c', 'slowNonNullErrorField'],
},
],
path: [],
},
],
hasNext: false,
},
](C) Null Bubbling Preserving Error Boundaries For the following operation: query {
... @defer {
a {
someField
b {
c {
nonNullErrorField
}
}
}
}
a {
... @defer {
b {
c {
d
}
}
}
}
}...the following payloads are generated: [
{
data: {
a: {},
},
hasNext: true,
},
{
incremental: [
{
data: {
a: {
b: {
c: null,
},
someField: 'someField',
},
},
errors: [
{
message:
'Cannot return null for non-nullable field c.nonNullErrorField.',
locations: [{ line: 8, column: 17 }],
path: ['a', 'b', 'c', 'nonNullErrorField'],
},
],
path: [],
},
{
data: {
b: {
c: { // <==== note that c is sent with data
d: 'd', // <==== even though the other payload bubbled up
},
},
},
path: ['a'],
},
],
hasNext: false,
},
] |
This was referenced Mar 30, 2023
yaacovCR
force-pushed
the
squashed
branch
3 times, most recently
from
da68be5 to
4b3c3f1
Compare
Contributor
Author
|
Moved deduplication out of this pr for now as per latest discussion… Extracted a few commits that start to minimize the diff…. |
yaacovCR
force-pushed
the
squashed
branch
2 times, most recently
from
562c6e9 to
d581d89
Compare
yaacovCR
force-pushed
the
squashed
branch
4 times, most recently
from
2236283 to
c383eaf
Compare
Contributor
Author
|
This PR has been updated to remove branching while retaining the original publisher. |
Contributor
Author
|
This PR has been updated to remove the stream refactoring that reduces ticks, so as to reduce the diff to facilitate review. |
Contributor
Author
|
@robrichard @IvanGoncharov @graphql/graphql-js-reviewers ready for review |
Contributor
Author
Contributor
Author
|
updated with a new test and some offline feedback from @robrichard |
the labels were only checked to be unique (and only have to be unique) in combination with the path at which they are used execute was never using the keys, just the values
Contributor
Author
|
closing in favor of #3886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this version of incremental delivery works without branching, solving the issue raised by @Keweiqu
see discussion here: graphql/defer-stream-wg#65
UPDATE: this is now ready for review
** huge thanks to @Urigo and @dotansimha of the guild for sponsoring my open-source work on this. **