diff-npm-package: create reports folder#3623

Merged

IvanGoncharov merged 2 commits intographql:mainfrom

Jun 1, 2022

Contributor

yaacovCR commented May 31, 2022

No description provided.


          diff-npm-package: create reports folder

ae09ff8

netlify Bot commented May 31, 2022 •

edited

Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
🔨 Latest commit	`97f032c`
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62975d48be734a00086161d5
😎 Deploy Preview	https://deploy-preview-3623--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yaacovCR requested a review from a team

May 31, 2022 12:47

yaacovCR added the PR: internal 🏠 label

n1ru4l approved these changes

View reviewed changes

saihaj approved these changes

View reviewed changes

IvanGoncharov requested changes

View reviewed changes

resources/diff-npm-package.ts Outdated

saihaj reviewed

View reviewed changes

resources/diff-npm-package.ts Outdated


          Apply suggestions from code review

97f032c

saihaj approved these changes

View reviewed changes

saihaj requested a review from IvanGoncharov

June 1, 2022 12:40

IvanGoncharov merged commit 7532a5c into graphql:main

Contributor Author

yaacovCR commented Jun 1, 2022

this is still actually (sadly) not working, although CI now is.

https://github.com/graphql/graphql-js/pull/3623/checks#step:7:7

Run actions/upload-artifact@v3
with:
name: npm-dist-diff.html
path: ./reports/npm-dist-diff.html
if-no-files-found: ignore
No files were found with the provided path: ./reports/npm-dist-diff.html. No artifacts will be uploaded.

will try to submit a fix

Contributor Author

yaacovCR commented Jun 1, 2022

never mind, sorry for the error, script doesn't generate a report if no diff is found.

on the other hand, the code change is a bit odd, as we are testing to see whether the file is present, and then if not, creating the directory with the path to the file. i guess it is working, but still a bit off.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation

ae54286

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR mentioned this pull request

diff-npm-package: fix reports dir creation #3624

Merged

IvanGoncharov pushed a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

540bb38

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

jasonkuhrt mentioned this pull request

refactor: treeshakable kind enum #4270

Merged

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

93c5c64

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

896894e

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

7651b19

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

e2a6df8

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

aa5ba0b

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

7c489bd

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

2c34d65

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

2cbec20

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

ccd877b

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

cd27d1c

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

e2c3d78

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

6f08492

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

ac51b1b

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

c0a0acf

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

5d382e5

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

8fe2170

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

dc2e93c

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

435eabf

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

82de238

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

04db3c0

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

0d3ecba

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: create reports folder (graphql#3623)

b418751

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          diff-npm-package: polish reports dir creation (graphql#3624)

b4f57e1

graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

67aecfb

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

1d90774

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

95de988

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

f245ffb

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

91e6067

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

3319c0d

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

4e69fe1

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

9bb7158

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR added a commit that referenced this pull request


          diff-npm-package: create reports folder (#3623)

5d4846e

Co-authored-by: Saihajpreet Singh <[email protected]>

yaacovCR added a commit that referenced this pull request


          diff-npm-package: polish reports dir creation (#3624)

d724ca0

#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.

yaacovCR deleted the fix branch

March 29, 2026 18:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: internal 🏠