Skip to content

Add KnownOperationTypes rule #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaacovCR merged 1 commit into from
Dec 5, 2024
Merged

Add KnownOperationTypes rule #3601

yaacovCR merged 1 commit into from
Dec 5, 2024

Conversation

@yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented May 20, 2022 •
edited
Loading

New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : #3592

@netlify
Copy link

netlify bot commented May 20, 2022 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 9797987
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670ecbdef3f674000855b822
😎 Deploy Preview https://deploy-preview-3601--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR added the spec RFC Implementation of a proposed change to the GraphQL specification label May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR mentioned this pull request May 20, 2022
Closed
@yaacovCR

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented May 20, 2022

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.1.canary.pr.3601.9a812ce71ad05c9dc089b40129f8295ca733e108
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3601

@yaacovCR yaacovCR mentioned this pull request May 20, 2022
Closed
@yaacovCR yaacovCR requested a review from a team May 20, 2022 07:28
IvanGoncharov
IvanGoncharov reviewed May 20, 2022
View reviewed changes
@yaacovCR yaacovCR force-pushed the known-operation-types branch from 36163fb to 304cef6 Compare May 20, 2022 09:17
@benjaminjkraft
Copy link

benjaminjkraft commented May 20, 2022

Neat, thanks!

IvanGoncharov
IvanGoncharov reviewed May 22, 2022
View reviewed changes
@saihaj saihaj mentioned this pull request May 24, 2022
Open
IvanGoncharov
IvanGoncharov approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍
So let's wait for stage2 to merge it.
Personally, I'm for fast-forwarding it to stage2 the next wg.

@n1ru4l n1ru4l mentioned this pull request May 25, 2022
Open
@benjaminjkraft
Copy link

benjaminjkraft commented Jun 1, 2022

For the sake of the record, the spec PR is now graphql/graphql-spec#955 and is scheduled for discussion on Thursday.

@yaacovCR yaacovCR mentioned this pull request Oct 15, 2024
Closed
@yaacovCR

This comment was marked as outdated.

Sign in to view
@yaacovCR yaacovCR force-pushed the known-operation-types branch from b3cc8f4 to 9797987 Compare October 15, 2024 20:09
@yaacovCR yaacovCR requested a review from JoviDeCroock October 15, 2024 20:09
@benjie
Copy link
Member

benjie commented Oct 18, 2024 •
edited
Loading

We're back to (an updated):

I'm happy to continue to champion this at the WG unless someone else would like to take it on.

@benjie benjie mentioned this pull request Nov 28, 2024
Merged
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Dec 5, 2024

This advanced to Stage 2 at the WG meeting from 12/5/2024 => so merging to at least v17.

@yaacovCR yaacovCR merged commit 50d555c into graphql:main Dec 5, 2024
@yaacovCR yaacovCR deleted the known-operation-types branch December 5, 2024 18:55
@JoviDeCroock JoviDeCroock added the PR: feature 🚀 requires increase of "minor" version number label Feb 6, 2025
@benjie benjie mentioned this pull request Feb 27, 2025
Open
17 tasks
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
e8d7616 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
e291f8d 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
a9a3b61 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
71dc590 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
1cbb2b0 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
Add KnownOperationTypes rule (graphql#3601)
67b633e 
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : graphql#3592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotansimha dotansimha dotansimha approved these changes

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

@saihaj saihaj saihaj approved these changes

@JoviDeCroock JoviDeCroock Awaiting requested review from JoviDeCroock

+1 more reviewer

@Shane32 Shane32 Shane32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: feature 🚀 requires increase of "minor" version number spec RFC Implementation of a proposed change to the GraphQL specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yaacovCR @benjaminjkraft @benjie @dotansimha @Shane32 @IvanGoncharov @saihaj @JoviDeCroock