lexer: fix expression to decode surrogate pairs#3278
Merged
IvanGoncharov merged 1 commit intographql:mainfrom Oct 19, 2021
Merged
lexer: fix expression to decode surrogate pairs#3278IvanGoncharov merged 1 commit intographql:mainfrom
IvanGoncharov merged 1 commit intographql:mainfrom
Conversation
Cito
force-pushed
the
fix-decode-surrogate-pair
branch
from
3bf6197 to
b1d1338
Compare
Member
|
@Cito Sorry for the long review time. |
IvanGoncharov
added
the
PR: bug fix 🐞
Member
Author
Hi @IvanGoncharov - have a look at the C function It doesn't matter whether you use '|' or '+' to combine the trailing and shifted leading values, because their bit patterns do not overlap. But you can't use '|' to add the |
IvanGoncharov
force-pushed
the
fix-decode-surrogate-pair
branch
from
544591d to
b1d1338
Compare
Member
|
@Cito Thanks for the PR and explanation. |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Oct 19, 2021
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Nov 1, 2021
* Export OperationTypeNode as value (graphql#3316) * Convert const "enum-like" maps to TS enums (graphql#3317) * Deprecate 'ASTKindToNode' (graphql#3318) * Add message that we only support TS >= 4.1.0 (graphql#3319) * Update deps (graphql#3320) * 16.0.0-rc.5 * jsutils: add test for Path functions (graphql#2478) Co-authored-by: Ivan Goncharov <[email protected]> * lexer: fix expression to decode surrogate pairs (graphql#3278) * Lexer: use standard JS functions to handle Unicode (graphql#3322) * GraphQLError-test: merge check of source with rest of the properties (graphql#3324) * GraphQLError: fix empty `locations` if error got nodes without locations (graphql#3325) * GraphQLError: enumerate only spec prescribed properties (graphql#3326) * GraphQLField: relax default value of TArgs to `any` (graphql#3328) * 16.0.0-rc.6 * Fix release instructions (graphql#3329) * use GITHUB_TOKEN (graphql#3330) * GraphQLError: Add test to check order of fields in JSON.stringify (graphql#3336) * Fix TS error caused by importing internal files directly (graphql#3339) * Use default GITHUB_ACTOR if unset (graphql#3331) Co-authored-by: Ivan Goncharov <[email protected]> * 16.0.0-rc.7 * version: force proper typing on version literals Types should be generic and stay the same across different versions E.g. `preReleaseTag` should be typed `string | null` even if it's a `null` literal for this particular release * build-npm: fix type inference during TS declarations build * version-test: fix validation of `versionInfo.preReleaseTag` (graphql#3345) * 16.0.0 * checkgit.sh: Added a check for local modifications (graphql#3347) * GraphQLError-test: text how extensions is inherited from originalError (graphql#3348) * fix lockfile * update graphql version * Remove unused upstream file * Upgrade deps * add changeset Co-authored-by: Ivan Goncharov <[email protected]> Co-authored-by: Christoph Zwerschke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the code point for a surrogate pair, the base code point of 0x10000 must be added, not bitwise ORed. Added some tests for catching this problem.