fix: Preserve deprecationReason on GraphQLInputFields#3257
Merged
IvanGoncharov merged 3 commits intographql:mainfrom Sep 6, 2021
Merged
fix: Preserve deprecationReason on GraphQLInputFields#3257IvanGoncharov merged 3 commits intographql:mainfrom
deprecationReason on GraphQLInputFields#3257IvanGoncharov merged 3 commits intographql:mainfrom
Conversation
trevor-scheer
force-pushed
the
fix-input-object-deprecation-reason
branch
from
f33cc7e to
ee1460a
Compare
trevor-scheer
force-pushed
the
fix-input-object-deprecation-reason
branch
from
ee1460a to
6ae37e5
Compare
IvanGoncharov
added a commit
that referenced
this pull request
Sep 6, 2021
Backported from #3257 Co-authored-by: Ivan Goncharov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQLInputObjectType.toConfig()currently doesn't preservedeprecationReasons on its fields. Anything internal depending on this function omits thedeprecationReasonfrom aGraphQLInputObjectType's fields.This was easy to remedy - we just needed to copy the field's
deprecationReasonproperty during the mapping of fields done intoConfig().I experienced this issue when using
extendSchemaon aGraphQLSchemaobject which had aGraphQLInputObjectTypewith fields marked@deprecated. The reason would be dropped from the extended schema.