Add 'UniqueArgumentDefinitionNamesRule' validation rule#3208
Merged
IvanGoncharov merged 1 commit intographql:mainfrom Oct 11, 2021
Merged
Conversation
IvanGoncharov
added
spec RFC
IvanGoncharov
changed the title
IvanGoncharov
force-pushed
the
UniqueArgumentDefinitionNamesRule
branch
from
b3595c7 to
2643c70
Compare
IvanGoncharov
added a commit
to graphql/graphql-spec
that referenced
this pull request
Jul 1, 2021
Background graphql/graphql-wg#50 graphql-js PR graphql/graphql-js#3208
This was referenced Jul 1, 2021
mjmahone
approved these changes
Jul 23, 2021
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
This looks necessary and the implementation seems correct in my view.
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Oct 11, 2021
Follow up to graphql#3208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background graphql/graphql-wg#505