Lexer: split part of refactoring from #3115#3155
Closed
IvanGoncharov wants to merge 6 commits intographql:mainfrom
Closed
Lexer: split part of refactoring from #3115#3155IvanGoncharov wants to merge 6 commits intographql:mainfrom
IvanGoncharov wants to merge 6 commits intographql:mainfrom
Conversation
IvanGoncharov
added
the
PR: polish 💅
IvanGoncharov
changed the title
Merged
Contributor
|
Thanks for this alt. Since this is only half the changeset - let me fold some of these review ideas back into my total PR. I'll have that up in a couple hours |
Member
Author
|
@leebyron Would be great thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extacted from #3115