Make specifiedByUrl in IntrospectionScalarType's flow type optional#2788
Merged
IvanGoncharov merged 1 commit intographql:masterfrom Sep 3, 2020
Merged
Make specifiedByUrl in IntrospectionScalarType's flow type optional#2788IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
…S type, and no longer be a breaking change
Member
|
@mjmahone Thanks 👍 Merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the flow definition of
specifiedByUrlidentical to the TS definition in https://github.com/graphql/graphql-js/blob/master/src/utilities/getIntrospectionQuery.d.ts#L65This also will make the next
graphql-jsrelease no longer have a breaking flow change compared to v15.0.0: I discovered this flow issue as I was upgrading from v15.0 to v15.3.