Skip to content

Support returning async iterables from resolver functions#2757

Merged
IvanGoncharov merged 2 commits intomainfrom
asynciteratable
Jun 23, 2022
Merged

Support returning async iterables from resolver functions#2757
IvanGoncharov merged 2 commits intomainfrom
asynciteratable

Conversation

@IvanGoncharov
Copy link
Copy Markdown
Member

@IvanGoncharov IvanGoncharov commented Aug 25, 2020 •
edited by robrichard
Loading

Continuation of #2712

Depends on #3134

@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Aug 25, 2020
@IvanGoncharov
Copy link
Copy Markdown
Member Author

IvanGoncharov commented Aug 25, 2020

@robrichard Since ATM we are using a very similar algorithm I'm worried that we will also have memory leak:
leebyron/iterall#24
So working on adding performance tests against it.

@IvanGoncharov IvanGoncharov force-pushed the asynciteratable branch 2 times, most recently from f612eb6 to d25cf40 Compare October 13, 2020 23:14
@gagoar gagoar mentioned this pull request Nov 27, 2020
Closed
Base automatically changed from master to main January 27, 2021 11:10
@robrichard robrichard mentioned this pull request Apr 6, 2021
Closed
@robrichard robrichard mentioned this pull request May 26, 2021
Merged
@robrichard robrichard force-pushed the asynciteratable branch 2 times, most recently from f1ddb83 to 10f12a1 Compare June 2, 2021 00:45
@robrichard robrichard mentioned this pull request Jun 2, 2021
Closed
@robrichard robrichard force-pushed the asynciteratable branch 4 times, most recently from e93482c to b393729 Compare June 4, 2021 15:10
@robrichard robrichard force-pushed the asynciteratable branch 2 times, most recently from 6415aa1 to 93bd84a Compare August 30, 2021 16:22
dnalborczyk
dnalborczyk reviewed Sep 23, 2021
View reviewed changes
@yaacovCR yaacovCR mentioned this pull request Oct 25, 2021
Merged
@github-actions github-actions bot mentioned this pull request Oct 26, 2021
Merged
@robrichard robrichard force-pushed the asynciteratable branch 2 times, most recently from 2153dda to fa38819 Compare October 28, 2021 20:56
@robrichard robrichard force-pushed the asynciteratable branch 3 times, most recently from c2d20a1 to 971ce43 Compare November 19, 2021 15:09
@robrichard robrichard force-pushed the asynciteratable branch 4 times, most recently from e8c1a70 to 09d56d6 Compare December 1, 2021 19:50
@yaacovCR
Copy link
Copy Markdown
Contributor

yaacovCR commented Jun 13, 2022

We decided at last js-wg to give this a few days, but it seems to have slipped. It looks good to me. @IvanGoncharov @saihaj ?

@IvanGoncharov IvanGoncharov merged commit 59c87c3 into main Jun 23, 2022
@IvanGoncharov IvanGoncharov deleted the asynciteratable branch June 23, 2022 18:19
@IvanGoncharov
Copy link
Copy Markdown
Member Author

IvanGoncharov commented Jun 23, 2022

@robrichard Merged, sorry for the long overdue review.
Hope it will help to accelerate steam/defer RFC 🚀

angelini pushed a commit to gadget-inc/graphql-js that referenced this pull request Aug 30, 2023
@IvanGoncharov @robrichard @angelini
Support returning async iterables from resolver functions (graphql#2757)
85c257f 
Co-authored-by: Rob Richard <[email protected]>
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
@TastyPi TastyPi mentioned this pull request May 7, 2025
Open
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
34fbe0b 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
74372c9 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
12f90c2 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
5975ddf 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
c46b2fa 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
545c8c1 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
bc427f6 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 22, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
cbbf3e7 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Dec 22, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
bca49af 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Dec 22, 2025
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
b66b307 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Jan 27, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (graphql#2757)
38f8b58 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 22, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
e96b453 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 23, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
12f9413 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 24, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
f1cdedb 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 24, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
9f7b307 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 24, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
a565751 
Co-authored-by: Rob Richard <[email protected]>
yaacovCR pushed a commit that referenced this pull request Feb 24, 2026
@IvanGoncharov @robrichard @yaacovCR
Support returning async iterables from resolver functions (#2757)
9fdbffc 
Co-authored-by: Rob Richard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaacovCR yaacovCR yaacovCR approved these changes

@saihaj saihaj saihaj approved these changes

@robrichard robrichard Awaiting requested review from robrichard

+1 more reviewer

@dnalborczyk dnalborczyk dnalborczyk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: feature 🚀 requires increase of "minor" version number

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanGoncharov @yaacovCR @dnalborczyk @robrichard @saihaj