Skip to content

NoDeprecatedCustomRule-test: simplify test cases#2720

Merged
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:pr_branch
Jul 25, 2020
Merged

NoDeprecatedCustomRule-test: simplify test cases#2720
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:pr_branch

Conversation

@IvanGoncharov
Copy link
Copy Markdown
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jul 25, 2020
enum EnumType {
NORMAL_VALUE
DEPRECATED_VALUE @deprecated(reason: "Some enum reason.")
DEPRECATED_VALUE_WITH_NO_REASON @deprecated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting up default deprecationReason is tested in buildASTSchema-test.js so no need to duplicate it here.

@IvanGoncharov IvanGoncharov merged commit 19f2c52 into graphql:master Jul 25, 2020
@IvanGoncharov IvanGoncharov deleted the pr_branch branch July 25, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant