Skip to content

Moved Maybe to jsutils folder and remove tsutils#2621

Merged
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:pr_branch2
Jun 6, 2020
Merged

Moved Maybe to jsutils folder and remove tsutils#2621
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:pr_branch2

Conversation

@IvanGoncharov
Copy link
Copy Markdown
Member

@IvanGoncharov IvanGoncharov commented Jun 6, 2020

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 6, 2020
@IvanGoncharov IvanGoncharov merged commit f2c2b78 into graphql:master Jun 6, 2020
@IvanGoncharov IvanGoncharov deleted the pr_branch2 branch June 6, 2020 12:56
@anisebamford anisebamford mentioned this pull request Jun 9, 2020
Closed
@wodka
Copy link
Copy Markdown

wodka commented Jun 10, 2020

This change breaks Apollo Server

node_modules/@apollo/federation/dist/composition/utils.d.ts:3:19
  error TS2307: Cannot find module 'graphql/tsutils/Maybe' or its corresponding type declarations.

import Maybe from 'graphql/tsutils/Maybe';

@IvanGoncharov
Copy link
Copy Markdown
Member Author

IvanGoncharov commented Jun 10, 2020

@wodka Thanks for reporting 👍
It is an internal type not intended to be used outside of our package that is why it's not exported through intex.d.ts.
Can you please report it to the Apollo team?

This was referenced Jun 10, 2020
Closed
Merged
Closed
This was referenced Sep 24, 2020
Closed
Closed
@jorgelbg jorgelbg mentioned this pull request Feb 25, 2021
Closed
2 tasks
@ValGeorgiev ValGeorgiev mentioned this pull request May 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IvanGoncharov @wodka