Added .d.ts files for test utils#2616
Closed
dotansimha wants to merge 3 commits intographql:mainfrom
dotansimha:fix-d-ts
Closed
Added .d.ts files for test utils#2616dotansimha wants to merge 3 commits intographql:mainfrom dotansimha:fix-d-ts
.d.ts files for test utils#2616dotansimha wants to merge 3 commits intographql:mainfrom
dotansimha:fix-d-ts
Conversation
Member
|
@dotansimha All the fixes in existing |
Co-authored-by: Ivan Goncharov <[email protected]>
Member
Author
|
@IvanGoncharov I saw you already moved the fixes to a new PR and merged, so that's great! Thank you. Do you think I should rebase #2609 to this PR? because those changes are needed in order to support the TS tests. |
Contributor
|
This can be closed considering that the code base has been converted to TS. Thank you @dotansimha for your work on this, which has been integrated into other PRs as well as for your energy and initiative in pushing forward the migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally from: #2609 , those fixes are required in order to make the tests compatible with TS.