TS: Fix incorrect enum typing in findBreakingChanges#2563
Merged
IvanGoncharov merged 1 commit intographql:masterfrom May 19, 2020
Merged
Conversation
IvanGoncharov
added
the
PR: bug fix 🐞
Member
|
@mwinstanley Thanks a lot 👍 |
This was referenced Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2084 (link to relevant part) updated the enums used in
findBreakingChanges.js, but did not update the corresponding types infindBreakingChanges.d.ts. Found this inconsistency when playing around withfindBreakingChangesin Typescript.This PR updates the typing to correspond with the implementation.