BlockString: print multi line for trailing backslash#2560
Merged
IvanGoncharov merged 1 commit intographql:masterfrom May 18, 2020
Merged
BlockString: print multi line for trailing backslash#2560IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
IvanGoncharov
requested changes
May 17, 2020
Member
IvanGoncharov
left a comment
IvanGoncharov
left a comment
There was a problem hiding this comment.
@hereisnaman Looks great 👍
The next step is to write tests.
IvanGoncharov
changed the title
Contributor
Author
Added a test. |
| expect(printBlockString(str, '', true)).to.equal( | ||
| joinLines('"""', 'backslash \\', '"""'), | ||
| ); | ||
| }); |
Member
There was a problem hiding this comment.
It makes more sense to move it one test up since it has the same logic as those tests.
Also joinLines make sense only in tests related to "indent".
Member
|
@hereisnaman Merged 🎉 |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jun 22, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jun 22, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Jun 22, 2020
This was referenced Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2512
\"""is not allowed inside aBlockString, so handled it by putting a\nbetween the backslash and triple quotes. The trailing '\n' are already handled.Thanks for the help @IvanGoncharov .