[cspell] migrate custom words to upstream dictionaries#2538
Merged
IvanGoncharov merged 2 commits intographql:masterfrom May 14, 2020
Merged
[cspell] migrate custom words to upstream dictionaries#2538IvanGoncharov merged 2 commits intographql:masterfrom
IvanGoncharov merged 2 commits intographql:masterfrom
Conversation
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "language": "en", | |||
| "dictionaries": ["softwareTerms"], | |||
Member
There was a problem hiding this comment.
If softwareTerms allows removing some words can you please do this in separate PR?
Contributor
Author
There was a problem hiding this comment.
Most of our custom words have been added to the softwareTerms dictionary in the mentioned PR. And changes to both en_us and software_terms at cspell_dicts will be merged in a single PR only.
Contributor
Author
There was a problem hiding this comment.
Also, just re-checked, all the dicts are auto included.
Member
|
@hereisnaman Also didn't mention in original issue but can you contribute these words into JS-specific vocabularies? |
Contributor
Author
Updated both PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once merged this will remove the custom words mentioned in the cspell config. Those words are under migration to the appropriate cspell dictionaries.
fixes: #2298
dependency: streetsidesoftware/cspell-dicts#184 (DO NOT MERGE BEFORE THIS)