Skip to content

Fix #2504 access field astNode's type by optional chaining#2513

Merged
IvanGoncharov merged 1 commit intographql:masterfrom
josephktcheung:fix/validate_error
May 7, 2020
Merged

Fix #2504 access field astNode's type by optional chaining#2513
IvanGoncharov merged 1 commit intographql:masterfrom
josephktcheung:fix/validate_error

Conversation

@josephktcheung
Copy link
Copy Markdown
Contributor

@josephktcheung josephktcheung commented Apr 17, 2020

This is to fix #2504 regression that throws TypeError not normal GraphQLError when running validateTypeImplementsInterface if astNode is not provided to GraphQLType

@IvanGoncharov
Copy link
Copy Markdown
Member

@josephktcheung Big thanks for investigating and fixing this issue 👍
The only question left: Why Flow didn't catch this?
But we plan to switch to TS so it's not a big deal.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 7, 2020
MrOrz added a commit to cofacts/rumors-api that referenced this pull request Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: bug fix 🐞 requires increase of "patch" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError in validateTypeImplementsInterface

2 participants