Remove 'iterall' as dependency. 'graphql' becomes zero dependency lib 🎉#2364
Merged
IvanGoncharov merged 1 commit intographql:masterfrom Jan 20, 2020
Merged
Remove 'iterall' as dependency. 'graphql' becomes zero dependency lib 🎉#2364IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
We used only couple functions from 'iterall' and it's the only dependency we have at the moment. Having no dependencies significantly simplify ESM builds and Deno support in future Partially resolves: graphql#2277 Bonus: All supported Node versions already natively support Array.from so it should improve perfomance
IvanGoncharov
added
the
PR: feature 🚀
|
This is awesome @IvanGoncharov 👏 one step closer to a browser compatible ESM build! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used only couple functions from 'iterall' and it's the only
dependency we have at the moment.
Having no dependencies significantly simplify ESM builds and Deno
support in future
Partially resolves: #2277
Bonus: All supported Node versions already natively support Array.from
so it should improve perfomance