parser: convert Location to be an ES6 class#2233
Merged
IvanGoncharov merged 1 commit intographql:masterfrom Oct 20, 2019
Merged
parser: convert Location to be an ES6 class#2233IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
IvanGoncharov
added
the
PR: breaking change 💥
Contributor
|
Note on this: we forgot to update the exports, so it's impossible for someone to create a new Location now. We only export Location as a type. |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 29, 2020
IvanGoncharov
added a commit
that referenced
this pull request
May 29, 2020
Reported here: #2233 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.