definitions: make constructed fields non-optional#2091
definitions: make constructed fields non-optional#2091IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
Reflects changes in graphql#2089
|
Not sure I understand the logic here: it seems to make it strictly more difficult to construct AST nodes by hand, as you now need to explicitly include undefined fields. |
|
@mjmahone It's not AST it's Why it's important: Having a stable set of properties significantly speed up execution since it allows V8 to reuse shadow classes: #2089 (comment) Since I plan to add |
|
Thanks! |
Reflects changes in #2089