Allow to add optional args to fields implemented from interfaces#1493
Merged
IvanGoncharov merged 1 commit intographql:masterfrom Aug 29, 2018
Merged
Conversation
mjmahone
approved these changes
Aug 29, 2018
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
Single typo nit, but this is great. Thank you!
| 'field AnotherInterface.field.', | ||
| locations: [{ line: 11, column: 44 }, { line: 7, column: 9 }], | ||
| 'Object field AnotherObject.field includes required argument ' + | ||
| 'requiredArg that is missing it the Interface field ' + |
Contributor
There was a problem hiding this comment.
'requiredArg that is missing from the Interface field '
| `is of required type ${inspect(objectArg.type)} but is not also ` + | ||
| `provided by the Interface field ${iface.name}.${fieldName}.`, | ||
| `Object field ${object.name}.${fieldName} includes required ` + | ||
| `argument ${argName} that is missing it the Interface field ` + |
Contributor
There was a problem hiding this comment.
argument ${argName} that is missing from the Interface field
Member
Author
There was a problem hiding this comment.
@mjmahone I'm grammatically challenged 😄
so I very appreciate your reviews 👍
IvanGoncharov
force-pushed
the
nonNullSchemaValidation
branch
from
b5ac3d3 to
87fcec8
Compare
Member
Author
|
@mjmahone Fixed. |
mjmahone
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reviewed all
isNonNullTypecalls and it the last one that needs to be fixed to complete #1274