Split out 'ASTValidationContext'#1446
Conversation
6640108 to
4a9505f
Compare
|
@mjmahone I decided to split it out of #1438 since it's pretty simple change.
Do you have use case for this class? Maybe we can reuse it for
I renamed
It to have context that validate basic things (e.g. unique arg names) without schema or any other additional data and can reuse both for GQL and SDL validations. Can you please review this PR? |
Yeah, that was my thought. It's also pretty common to want to "collect but not throw errors", and then throw them all at once. Having a default error reporter provided by
Makes sense. Thanks for putting this up! |
|
@mjmahone BTW. I figure out we should keep all these new classes and function private until |
|
That makes sense, and I agree. Thanks for thinking through it. |
Splited from #1438