Replace '.getDirectives' with generic method#1436
Merged
mjmahone merged 1 commit intographql:validate-schema-directivesfrom Jul 27, 2018
Merged
Conversation
IvanGoncharov
force-pushed
the
validate-schema-directives2
branch
from
59687d8 to
57619c9
Compare
mjmahone
approved these changes
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjmahone It's PR on top of #1435 so it will be merged on your feature branch.
There some technical issues with #1435 but
.getDirectivesis a major one.This PR shows that you don't need this function and could use generic one instead.
If you need this functionality for Relay we can figure out how to make generic function public.
Motivation:
*.getDirectivesconflicts with #1343 and more global effort to expose directives through introspection: graphql/graphql-spec#300Also, we shouldn't add methods that are easily implemented as an external function or we will get a bunch of "god" classes.