Replace all 'Array.forEach' with 'for of' cycle#1423
Merged
mjmahone merged 1 commit intographql:masterfrom Jul 17, 2018
Merged
Conversation
mjmahone
approved these changes
Jul 17, 2018
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
I personally disagree with for of being more readable, but I come from a very functional-language background. The performance benefit though is tangible and significant enough that I'm on board!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjmahone
for ofis 4x faster thanforEach+ arrow function: https://jsperf.com/for-of-vs-foreach5If we enable
loosemode forfor ofthan it will be 12x speedup.Also,
for ofdon't force us to create closures so it should lower memory usage in recursive functions.But more importantly, the main purpose of this library is to be the reference implementation of GraphQL so code readability is very important.