Fix extensionASTNodes assigment#1390
Merged
leebyron merged 2 commits intographql:masterfrom Jun 14, 2018
Merged
Conversation
This was referenced Jun 12, 2018
Merged
mjmahone
approved these changes
Jun 13, 2018
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
Thanks for going through this comprehensively, @IvanGoncharov ! This looks really good to me.
|
|
||
| it('does not allow replacing a default directive', () => { | ||
| const ast = parse(` | ||
| const sdl = ` |
Contributor
There was a problem hiding this comment.
I like this, but want to make sure I understand our guidelines for sdl vs ast: sdl => used when we have TypeSystemDefinitionNode types, and ast for ExecutableDefinitionNode types?
Member
Author
There was a problem hiding this comment.
@mjmahone SDL - is a string containing TypeSystemDefinitions
AST - a result of parse being called on any string in GraphQL syntax.
Contributor
|
Awesome thanks for spotting and catching this before release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup tests in preparation to #1388 and also found a bug with
extensionASTNodes