CI: fix nyc doesn't proxy error status from mocha#1353
Merged
kassens merged 1 commit intographql:masterfrom May 23, 2018
Merged
CI: fix nyc doesn't proxy error status from mocha#1353kassens merged 1 commit intographql:masterfrom
kassens merged 1 commit intographql:masterfrom
Conversation
Closed
Member
Author
|
@kassens Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue introduced in #1342
It results in one node version always being green even if others will fail:
https://travis-ci.org/graphql/graphql-js/builds/379852096?utm_source=github_status&utm_medium=notification
Fix is based on this comment: istanbuljs/nyc#433 (comment)