Validate Input Objects do not contain non-nullable circu…#1352
Validate Input Objects do not contain non-nullable circu…#1352spawnia wants to merge 2 commits intographql:masterfrom spawnia:master
Conversation
…lar references The first two to tests are there to avoid false positives when checking for circular references. Tests 3 and 4 are failing right now but show what should happen. graphql/graphql-spec#445 contains the proposed additions to the spec.
|
@spawnia Thanks for PR, your SDL examples look great 👍 However graphql-js/src/type/validate.js Lines 48 to 57 in 4aca994 Can you please move your tests here: |
|
@spawnia Preferably test cases should match examples from graphql/graphql-spec#445 |
IvanGoncharov
added
the
spec RFC
…te file Todo: Actually implement the validation rule, possibly add some more tests
|
Unfortunately, implementation of this is not trivial and i think i will not be able to do it soon, i might implement it in PHP since i know that better. It would be cool if maybe someone who has more experience with the project can take a shot of doing the actual validation? |
spawnia
changed the title
|
@spawnia Don't want this proposal to stuck so I created a draft implementation in #1359. I don't think it's ready to be merged but hopefully, it allows us to continue the conversation in graphql/graphql-spec#445 |
|
Yep, thank you a lot for implementing this! Closed in favour of #1359 |
3 participants
…lar references
The first two to tests are there to avoid false positives when checking for circular references.
Tests 3 and 4 are failing right now but show what should happen.
graphql/graphql-spec#445 contains the proposed additions to the spec.