Skip to content

Babel 7 preparation: Switch babel config to JS#1348

Merged
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:babelrcToJS
Jun 1, 2018
Merged

Babel 7 preparation: Switch babel config to JS#1348
IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov:babelrcToJS

Conversation

@IvanGoncharov
Copy link
Copy Markdown
Member

Comment thread .babelrc
["transform-es2015-destructuring", {"loose": true}],
["transform-es2015-spread", {"loose": true}]
]
"presets": ["./.babelrc.js"]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remove this file after switching to Babel7

@IvanGoncharov IvanGoncharov requested a review from mjmahone May 14, 2018 15:34
@IvanGoncharov IvanGoncharov mentioned this pull request May 22, 2018
@leebyron
Copy link
Copy Markdown
Contributor

want to resolve conflicts here?

@IvanGoncharov
Copy link
Copy Markdown
Member Author

@leebyron Done

@IvanGoncharov
Copy link
Copy Markdown
Member Author

@leebyron Already rebased + it blocks #1350. Can I merge it?

Copy link
Copy Markdown
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we're going to pull the 14.0 trigger for the next release, so let's merge this so we can do the babel 7 upgrade.

@IvanGoncharov IvanGoncharov merged commit eb8ef7a into graphql:master Jun 1, 2018
@IvanGoncharov IvanGoncharov deleted the babelrcToJS branch June 1, 2018 08:10
@IvanGoncharov
Copy link
Copy Markdown
Member Author

@mjmahone Thanks for the review 👍 Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants