Coverage: Switch isparta to nyc#1342
Merged
mjmahone merged 1 commit intographql:masterfrom May 11, 2018
Merged
Conversation
IvanGoncharov
force-pushed
the
simplifyScripts
branch
from
6e79350 to
e7b0e03
Compare
IvanGoncharov
force-pushed
the
simplifyScripts
branch
from
e7b0e03 to
089d6df
Compare
mjmahone
approved these changes
May 11, 2018
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
TIL coverage report libraries exist.
Contributor
|
Thank you for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isparta produces incorrect coverage reports:
Moreover there is zero chance it will be fixed since
ispartais officially unmantained.So I switched
ispartato nyc which is official CLI for istanbul and also replacedbabel-nodeworkaround with offically recomendedbabel-registry/babel-polyfill.