Skip to content

extendSchema: Use consistent naming + inline 'getExtendedType' func#1327

Merged
mjmahone merged 1 commit intographql:masterfrom
IvanGoncharov:extendRename
May 14, 2018
Merged

extendSchema: Use consistent naming + inline 'getExtendedType' func#1327
mjmahone merged 1 commit intographql:masterfrom
IvanGoncharov:extendRename

Conversation

@IvanGoncharov
Copy link
Copy Markdown
Member

@IvanGoncharov IvanGoncharov commented Apr 27, 2018

Based on this discussion: #1322 (comment)
I think naming should be consistent with types and predicates:

graphql-js/src/type/definition.js

Lines 52 to 63 in ae5b163

export function isType(type: mixed): boolean %checks {
return (
isScalarType(type) ||
isObjectType(type) ||
isInterfaceType(type) ||
isUnionType(type) ||
isEnumType(type) ||
isInputObjectType(type) ||
isListType(type) ||
isNonNullType(type)
);
}

graphql-js/src/type/definition.js

Lines 462 to 471 in ae5b163

export function isNamedType(type: mixed): boolean %checks {
return (
isScalarType(type) ||
isObjectType(type) ||
isInterfaceType(type) ||
isUnionType(type) ||
isEnumType(type) ||
isInputObjectType(type)
);
}

@IvanGoncharov IvanGoncharov mentioned this pull request Apr 27, 2018
Closed
@leebyron
Copy link
Copy Markdown
Contributor

leebyron commented Apr 30, 2018

Makes sense to me - do you mind rebasing?

@IvanGoncharov
Copy link
Copy Markdown
Member Author

IvanGoncharov commented May 1, 2018

@leebyron Rebased

@mjmahone mjmahone merged commit 0276d68 into graphql:master May 14, 2018
@mjmahone
Copy link
Copy Markdown
Contributor

mjmahone commented May 14, 2018

Thank you!

@IvanGoncharov IvanGoncharov deleted the extendRename branch May 15, 2018 09:22
This was referenced Jul 1, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IvanGoncharov @leebyron @mjmahone @facebook-github-bot