Make "nonnull-test.js" more explicit#1311
Merged
leebyron merged 5 commits intographql:masterfrom Apr 18, 2018
Merged
Conversation
Contributor
|
Looks like this has merge conflicts and test failures - want to take another look, @IvanGoncharov ? |
IvanGoncharov
force-pushed
the
nonullTests
branch
from
872bef8 to
21bb901
Compare
Member
Author
|
@leebyron Rebased and fixed. The reason was that #1286 changed the order of errors in a promise-heavy test. Not a problem since the order of error is implementation dependent. Maybe it worth to sort them, somehow? It went unnoticed on master since |
Contributor
|
Aha, I'm glad we're migrating away from containSubset - the array order thing is not what I would have suspected |
Contributor
|
Thanks for cleaning this up! It's much easier to follow now and I'm happy to see |
This was referenced Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was really hard to read those tests.
Moreover, explicit version is shorter and this PR increase line count only because I added
pathto every error.