Error: make 'path' and 'locations' enumerable only if present#1305
Merged
leebyron merged 2 commits intographql:masterfrom Apr 6, 2018
Merged
Error: make 'path' and 'locations' enumerable only if present#1305leebyron merged 2 commits intographql:masterfrom
leebyron merged 2 commits intographql:masterfrom
Conversation
Contributor
|
This looks great - do you mind rebasing and looking at the tests? Looks like the build is failing with test failures |
Also cleanup tests from 'undefined' and 'containSubset'.
IvanGoncharov
force-pushed
the
errorCleanup
branch
from
30f6e73 to
46f9f09
Compare
Member
Author
|
@leebyron Fixed. To make validation tests less fragile I made them expect a subset of errors. |
Contributor
|
That seems okay, but I'm not sure that I would agree that makes them less fragile - it just means they're more likely to pass when really there is an error. Ideally these should detect the exact set of schema validation errors and we should write the test so that each test introduces only the validation error it expects to catch |
Contributor
|
Going to merge this, but we should still try to improve those tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also cleanup tests from 'undefined' and 'containSubset'.
@leebyron I split up non-breaking changes from #1284
I think they are useful by itself since they make tests more readable.