Add 'introspectionFromSchema' utility function#1187
Merged
leebyron merged 1 commit intographql:masterfrom Jan 8, 2018
Merged
Conversation
leebyron
reviewed
Jan 8, 2018
| export function introspectionFromSchema( | ||
| schema: GraphQLSchema, | ||
| options: IntrospectionOptions, | ||
| ): IntrospectionQuery { |
Contributor
There was a problem hiding this comment.
Just a note, it seems like the response type of this should be named IntrospectionResult
Member
Author
There was a problem hiding this comment.
@leebyron It's pretty confusing name but it already defined here:
Would be great to rename it to
IntrospectionResult but I'm not sure how much code it will brake 😞
Contributor
|
Nice |
This was referenced Mar 19, 2018
This was referenced May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1114 by @mjmahone
I think it's better to use
executeinstead ofgraphqlsince you are not spending time validation introspection query. Butexecuterequired parsed query so it's not an one-liner anymore.Checking for
errorsis also a good practice even those introspection query should produce them.And finally, you should manually cast the result to
IntrospectionQuerytype.That's why I think we should have this wrapper function inside lib.