Update printSchema for recent SDL change to implements.#1179
Merged
leebyron merged 1 commit intographql:masterfrom Jan 8, 2018
Merged
Update printSchema for recent SDL change to implements.#1179leebyron merged 1 commit intographql:masterfrom
implements.#1179leebyron merged 1 commit intographql:masterfrom
Conversation
| return printSchema(schema); | ||
| const schemaText = printSchema(schema); | ||
| buildSchema(schemaText); // keep printSchema and buildSchema in sync | ||
| return schemaText; |
Member
There was a problem hiding this comment.
@mohawk2 It would be great to also test output of buildSchema:
expect(printSchema(buildSchema(schemaText))).to.equal(schemaText)
Added test to prevent future regressions. Updated existing also.
mohawk2
force-pushed
the
update-schema-print
branch
from
ba968da to
632a742
Compare
Contributor
Author
|
@IvanGoncharov Agreed, changed! |
Contributor
|
Great catch! Thanks for the added test coverage |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test to prevent future regressions. Updated existing also.