Subscriptions: report resolver errors during initialization#1107
Merged
Subscriptions: report resolver errors during initialization#1107
Conversation
Contributor
Author
|
Currently this PR just expands on the test to illustrate failure. 3 of the 4 cases are consistent, but the 4th case (rejected promise) results in different behavior, rejecting the containing promise for the subscription itself. @robzhu do you remember if this behavior was intentional? |
robzhu
reviewed
Dec 4, 2017
Contributor
robzhu
left a comment
robzhu
left a comment
There was a problem hiding this comment.
You're right, the four cases you identified should all behave consistently.
leebyron
force-pushed
the
subscription-setup-error
branch
2 times, most recently
from
93654ab to
d8ecbbb
Compare
Expanding on the tests to cover all forms of subscription resolver errors.
…r not applying the same error-catching behavior to Promises. This causes different tests to fail, so I'll investigate those next.
leebyron
force-pushed
the
subscription-setup-error
branch
5 times, most recently
from
40c88e8 to
451753c
Compare
leebyron
force-pushed
the
subscription-setup-error
branch
from
451753c to
b0c3e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding on the tests to cover all forms of subscription resolver errors.