fix elasticsearch errors being mistaken for graphql errors#1090
Merged
leebyron merged 1 commit intographql:masterfrom Nov 30, 2017
Merged
fix elasticsearch errors being mistaken for graphql errors#1090leebyron merged 1 commit intographql:masterfrom
leebyron merged 1 commit intographql:masterfrom
Conversation
Contributor
|
Nice, thanks for adding tests! |
Contributor
Author
|
@leebyron no worries, thanks for the awesome library! |
This was referenced Apr 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch records its index path and attaches it to errors. Its useful, but sadly that
pathproperty means that graphql-js assumes that an elasticsearch error is a GraphQLError, and so the index path gets leaked instead of the useful graphql query path.The fix is to be a little bit stricter.
There is probably a better fix to recognise a GraphQLError across contexts, but this will at least improve the situation. Plus, the added tests should make any better solution easier to test.