Correct types for 'path' & 'parentType' of GraphQLResolveInfo#1033
Merged
leebyron merged 3 commits intographql:masterfrom Dec 1, 2017
Merged
Correct types for 'path' & 'parentType' of GraphQLResolveInfo#1033leebyron merged 3 commits intographql:masterfrom
leebyron merged 3 commits intographql:masterfrom
Conversation
IvanGoncharov
force-pushed
the
correctTypes
branch
from
2d43dd6 to
ccae918
Compare
Member
Author
|
I rebased this PR. |
Contributor
|
Thanks for rebasing, I'm taking a look now |
leebyron
reviewed
Dec 1, 2017
| fieldNodes: Array<FieldNode>; | ||
| returnType: GraphQLOutputType; | ||
| parentType: GraphQLCompositeType; | ||
| parentType: GraphQLObjectType; |
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I corrected types for
pathandparentTypefields ofGraphQLResolveInfo.Without this info, I forced to add additional checks to my resolvers:
Both checks always true and this is obvious from code of buildResolveInfo function.
But I forced to add above checks in all my resolvers 😞
@wincent This PR affects only typings and doesn't change any runtime behaviour. Can you please review it?