You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wincent I was wondering why Flow silently ignored missing export. So I discovered that a few files missing @flow directive.
And lexer.js had /* @flow / since the first commit, not sure how Flow is parsing such comments.
I also unify @flow directives to always be in a first line, so you can use simple shell script to find all files without it.
After enabling flow checks on more files two new issue appeared which I fixed in the separate commit.
FWIW I don't really like the hoisting up of the @flow annotation to the top; it smells of special-casing to me and @flow shouldn't be more special than any other annotation that we might use (and we do use quite a few at FB). Having said that, consistency is good, and there is a precedent for this style, so... ¯\(ツ)/¯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #988 I forget to export
ExecutionArgsin all necessary places 🤦♂️This one-line PR fix that.
@wincent Can you please review it?