[ESLint] enable unicorn/prefer-at rule#3046
Merged
dimaMachina merged 2 commits intographql:mainfrom Mar 4, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f4e6d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Feb 25, 2023
Comment on lines
-47
to
-64
| function indent( | ||
| this: CodeMirror.Mode<any> & { | ||
| electricInput?: RegExp; | ||
| config?: CodeMirror.EditorConfiguration; | ||
| }, | ||
| state: State, | ||
| textAfter: string, | ||
| ) { | ||
| const { levels, indentLevel } = state; | ||
| // If there is no stack of levels, use the current level. | ||
| // Otherwise, use the top level, preemptively dedenting for close braces. | ||
| const level = | ||
| !levels || levels.length === 0 | ||
| ? indentLevel | ||
| : levels[levels.length - 1] - | ||
| (this.electricInput?.test(textAfter) ? 1 : 0); | ||
| return (level || 0) * (this.config?.indentUnit || 0); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
saw this same function copied in 2 other files, removed and just imported
dimaMachina
commented
Feb 25, 2023
| !params.contentChanges || | ||
| !params.textDocument.uri | ||
| ) { | ||
| if (!params?.textDocument?.uri || !params.contentChanges) { |
Collaborator
Author
There was a problem hiding this comment.
I simplified it
acao
approved these changes
Mar 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.