feature: add fragment arguments syntax highlights#3019
Conversation
🦋 Changeset detectedLatest commit: be97679 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👍🏻 looks right overall to me, didn't run it locally but the regexes seem right |
|
looks great, thank you @mjmahone ! we hope to be able to publish again by next week... though I guess there is a way I can publish just the vscode syntax extension locally... |
Next week would certainly be soon enough: I think right now I'm just making sure all the work items for fragment args are making progress and figuring out what, if any, of the blockers are. Syntax highlighting was the biggest blocker to trying it in Relay, but there are still a few other (namely, graphql-js syntax additions and Relay parsing support) that have not yet been merged. Thanks @acao ! |
|
going to go ahead and merge for now, thanks again! just noting for the future - this feels like a regression that may have been introduced with another fix in the recent past. we don't have a great way to test this yet, though there is now a way to test the static highlighting it would seem |
3 participants
Adding fragment argument syntax highlighting to VSCode. This is needed as per discussion in graphql/graphql-wg#1239 (comment)
Before:
After:
To test this:
test.graphqlfile and ensure syntax highlighting is working as expected.graphiql/packages/vscode-graphql-syntax/grammars/graphql.jsonto~/.vscode/extensions/graphql.vscode-graphql-syntax-1.0.6/grammars/graphql.jsonProbably the fast-devex way to make changes here is to have some
ln -ssymlink from~/.vscode/extensions/tographiql/packages/vscode-graphql-syntax, but this change was simple enough that I didn't need that quick an iteration cycle.