chore: render query history panel only when it's toggled#1821
chore: render query history panel only when it's toggled#1821acao merged 5 commits intographql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6dd3198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ah! i think there's a bug in the new github actions workflow config where it doesn't work on PR create. if you push another commit it should test and deploy. I'll need to go fix that! |
|
hmm! still no dice! strange. but the PR looks great, thank you! |
harshithpabbati
force-pushed
the
query-history-panel
branch
2 times, most recently
from
c957c7b to
4c94685
Compare
harshithpabbati
force-pushed
the
query-history-panel
branch
from
4c94685 to
c636a3a
Compare
|
this is a good move, thanks @harshithpabbati ! |
|
hmm, test cases failed because the history panel is no more available in dom. |
|
it should be once it's toggled open! |
yup, did that! |
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
+ Coverage 65.66% 65.83% +0.16%
==========================================
Files 85 85
Lines 5115 5108 -7
Branches 1635 1633 -2
==========================================
+ Hits 3359 3363 +4
+ Misses 1752 1741 -11
Partials 4 4
Continue to review full report at Codecov.
|
|
thank you again @harshithpabbati ! |
|
@harshithpabbati just need to fix the formatting bug, may have been introduced by changesets. thus why its easier when you run |
|
@acao, fixed it! |
2 participants
Rendering the history panel only when it's toggled instead of using CSS to hide it.