🦋 Changeset detected

Latest commit: 0f1d417

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codecov Report

Merging #1819 (aa238af) into main (3e2c9c8) will increase coverage by 0.03%.
The diff coverage is 83.33%.

❗ Current head aa238af differs from pull request most recent head 0f1d417. Consider uploading reports for the commit 0f1d417 to get more accurate results

@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
+ Coverage   65.66%   65.70%   +0.03%     
==========================================
  Files          85       85              
  Lines        5115     5106       -9     
  Branches     1635     1631       -4     
==========================================
- Hits         3359     3355       -4     
+ Misses       1752     1747       -5     
  Partials        4        4              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2c9c8...0f1d417. Read the comment docs.

@junminstorage would this unblock you?

Yes, it does. having client to inject its own wsClient or legacyClient is great so createFetcher util can have the flexibility of not tied to any versions of clients if upgrades are needed.

@junminstorage should we specify peerDependency ranges and/or optionalDependencies do you think?

I am not super familiar with the difference between those two, it looks like peerDependency is better fit since the create-fetcher's lib.ts imports the two clients, and the legacy client is only used for type checking, so is it devDependency?

I am not super familiar with the difference between those two, it looks like peerDependency is better fit since the create-fetcher's lib.ts imports the two clients, and the legacy client is only used for type checking, so is it devDependency?

yes good thinking. the legacy client should be a devDependency, and then ws-client should be a peer dependency with ranges we support