Skip to content

escape a pipe in table so that row correctly closes#1810

Merged
imolorhe merged 2 commits intographql:mainfrom
mangano-ito:correct-props-table
Mar 17, 2021
Merged

escape a pipe in table so that row correctly closes#1810
imolorhe merged 2 commits intographql:mainfrom
mangano-ito:correct-props-table

Conversation

@mangano-ito
Copy link
Copy Markdown
Contributor

@mangano-ito mangano-ito commented Mar 15, 2021 •
edited
Loading

Hi,

It looks like the definition of externalFragments gets chopped down unintentionally
because of an unescaped pipe character in the code block.

Thank you.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 15, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d6ffb5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 15, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2021 •
edited
Loading

Codecov Report

Merging #1810 (d6ffb5b) into main (b538f6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1810   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files          85       85           
  Lines        5115     5115           
  Branches     1624     1635   +11     
=======================================
  Hits         3359     3359           
  Misses       1752     1752           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b538f6e...d6ffb5b. Read the comment docs.

@imolorhe imolorhe merged commit a1b8076 into graphql:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@imolorhe imolorhe imolorhe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mangano-ito @imolorhe