Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
- Coverage 65.62% 65.61% -0.02%
==========================================
Files 85 85
Lines 5102 5115 +13
Branches 1610 1624 +14
==========================================
+ Hits 3348 3356 +8
- Misses 1727 1755 +28
+ Partials 27 4 -23
Continue to review full report at Codecov.
|
set build output to root (to align with current behavior)
| "scripts": { | ||
| "build": "yarn run build-clean && yarn build-ts && yarn build-babel", | ||
| "build-babel": "yarn workspace codemirror-graphql run build", | ||
| "build": "yarn tsc --clean && yarn tsc", |
| .replace(tempRenamePath, dest), // and destination path | ||
| ); | ||
|
|
||
| mkdirp.sync(path.dirname(destinationPath)); |
| import * as CM from 'codemirror'; | ||
| import 'codemirror/addon/hint/show-hint'; | ||
|
|
||
| declare module 'codemirror' { |
There was a problem hiding this comment.
thank you for setting this up so nicely with the global declare and all. what do you think of calling this file types/codemirror.d.ts ? unnecessary? we need to improve this on the graphiql side as well but we can do that in another PR if you prefer. it's exciting how this really brings the whole codebase together!
There was a problem hiding this comment.
We should be able to rename it without issues
|
oh crap @imolorhe we forgot the changeset :// |
|
Oh right! That can be another PR right? |
* Migrated codemirror-graphql to typescript * Migrated codemirror-graphql tests to typescript * Cleaned up codemirror-graphql package.json set build output to root (to align with current behavior) * ignore generated __tests__ folder from eslint * Updated codemirror typing * Updated codemirror typing * Updated ci-e2e script * Exclude babel and jest config from npm files
2 participants
Moving all codemirror-graphql logic to typescript.