feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign by acao · Pull Request #1468 · graphql/graphiql

acao · 2020-04-06T03:37:58Z

moved to a non forked branch, #1523

…hql#1380) * Initial migration context wrapper * Pull out other static properties * Fix refs bug by properly accessing current

Co-Authored-By: Justin Bennett <[email protected]>

… an enum and discriminated union

* made errors consitent across providers * allowed for multiple errors * preserved error objects to allow more custom usage

* eslint-plugin-react-hooks * Move query facts out of session state * Rename sessionReducer

* used the return type of the action creators for the action types

…ntext-hooks

harshithpabbati · 2020-05-07T02:17:39Z

next steps:

merge in @harshithpabbati's PR above

yank out changes to most everywhere except packages/graphiql, thus maybe a few smaller, pre-cursory PRs. for example, improvements to monaco-graphql anbd the LSP to suit this PR can be broken out into it's own PR. this PR should be packages/graphiql and whatever tooling/etc changes required

new directions:

if someone wants to spike a PR adding react-i18n-next to this, that would be rad. there's a lingering closed PR that did this with russian translations. the author had also rewrote a significant portion of the codebase in the PR and he didn't make a simplified version.

A PR to pull doc explorer into a new, seperate npm package named @graphiql-plugins/doc-explorer-classic and import as a prop, or to replace it with a green plugin component for the new doc explorer :D. repeat with query explorer!

spike off this PR to add a PluginManagerContext for rendering plugin components that invoke API behaviors

adding a bunch of cool components and improvements to the new src/components/common

@acao shall I start with pulling the doc-explorer component to @graphiql-plugins/doc-explorer-classic ?

…o feat/use-context-hooks

acao · 2020-05-07T02:43:08Z

@harshithpabbati I've been working on that and the props interface for tabs today, taking care of a sick family member as well so I haven't finished. Would you be interested in taking a pass at adding react-i18n-next? just to add tooling and to handle the english locale strings for one or a few components to get started, or you could go all out on that if you want!

harshithpabbati · 2020-05-07T02:57:18Z

@harshithpabbati I've been working on that and the props interface for tabs today, taking care of a sick family member as well so I haven't finished. Would you be interested in taking a pass at adding react-i18n-next? just to add tooling and to handle the english locale strings for one or a few components to get started, or you could go all out on that if you want!

Yeah, sure I will look into it.

harshithpabbati · 2020-05-07T02:59:39Z

@harshithpabbati I've been working on that and the props interface for tabs today, taking care of a sick family member as well so I haven't finished. Would you be interested in taking a pass at adding react-i18n-next? just to add tooling and to handle the english locale strings for one or a few components to get started, or you could go all out on that if you want!

I wish he/she get well soon

acao · 2020-05-08T00:05:05Z

thank you! she will be ok, she doesn’t have covid thankfully, still taking care of her though

so, the effort of pluginifying doc explorer is taking a bit longer but we’re almost there! i fixed the editor display locally.

acao · 2020-05-09T15:10:42Z

@harshithpabbati merged! now you'll want to update your i18n PR

harshithpabbati · 2020-05-09T15:11:41Z

@acao yeah, I am on it!

acao · 2020-05-11T19:17:17Z

hmm... I've think I've gone one bridge too far bringing the plugin ecosystem into this PR. heads up @harshithpabbati, going to revert my last three commits and we can make another branch for the plugin effort to be based off of

Co-Authored By: Harshith Pabbati <[email protected]>

harshithpabbati · 2020-05-12T12:07:28Z

@acao type in commit-msg
it should be Co-authored-by: harshithpabbati <[email protected]>

acao · 2020-05-13T15:08:14Z

moving to #1523

acao and others added 20 commits March 15, 2020 14:56

feat: schema provider using context/useReducer

1968a68

chore: cleanup, ts improvements

9452b12

WIP: feat: Add migration context to enable GraphiQL refactoring (grap…

a8d35ca

…hql#1380) * Initial migration context wrapper * Pull out other static properties * Fix refs bug by properly accessing current

feat: use context for schema and sesion state

91b4bf2

feat: results viewer as FC, purely context for op + results

d62507d

feat: doc explorer and query history using context

6ea0289

chore: temporarily disable graphiql unit tests

a174c58

chore: temporarily disable e2e tests for build

9f5c458

chore: use nullish coalescing operator, thanks @zephgraph

9d8ce9c

Co-Authored-By: Justin Bennett <[email protected]>

chore: cleanup ExecuteButton

aa832b1

feat: use static local/remote schemas

246c51e

Merge branch 'master' into feat/use-context-hooks

97f347f

feat: updated session reducer to have better typescript typings using…

dfc4fbd

… an enum and discriminated union

feat: updating typings and structure of schema reducer

99c7f4c

fix: removed comment

ac9dc70

feat: added observable support back to fetcher function

754c327

feat: standardized error handling

1e6f5d3

* made errors consitent across providers * allowed for multiple errors * preserved error objects to allow more custom usage

feat: schema provider - query facts out of session state, unwrap reducer

ea276e8

* eslint-plugin-react-hooks * Move query facts out of session state * Rename sessionReducer

fix: fixed import pathing issue

4b3ef26

feat: action types

c9d29e9

* used the return type of the action creators for the action types

cshaver mentioned this pull request Apr 6, 2020

refactor: useCallback in GraphiQLSchemaProvider #1467

Closed

refactor: useCallback in GraphiQLSchemaProvider

67bf769

acao mentioned this pull request Apr 6, 2020

feat: schema provider and operation session context using context/useReducer #1359

Closed

acao changed the title ~~Feat/use context hooks~~ feat: schema provider and operation session context using context/useReducer Apr 6, 2020

ryan-m-walker and others added 6 commits April 6, 2020 22:56

fix: made execute buttons not be reassigned

131ecbd

Merge branch 'master' into feat/use-context-hooks

caf6cfe

Merge branch 'master' into feat/use-context-hooks

ba0091d

ci: fix lockfile

ae40808

Merge branch 'master' of github.com:graphql/graphiql into feat/use-co…

900409e

…ntext-hooks

chore: schema no longer needed in variables editor

ba78c5c

fix: build issues

8207c20

Merge branch 'feat/use-context-hooks' of github.com:acao/graphiql int…

58f9a4a

…o feat/use-context-hooks

fix: clean up unused dependencies from last PR

9afaf1a

acao force-pushed the feat/use-context-hooks branch from c6193c4 to d199a94 Compare May 9, 2020 15:53

harshithpabbati reviewed May 9, 2020

View reviewed changes

Comment thread plugins/doc-explorer-classic/src/index.ts Outdated

acao force-pushed the feat/use-context-hooks branch from d1b4851 to f3925b6 Compare May 9, 2020 16:21

acao force-pushed the feat/use-context-hooks branch 2 times, most recently from 5dec9be to 429b488 Compare May 11, 2020 21:28

acao changed the title ~~feat: [RFC] Rewrite for Monaco, Context, Plugins and Redesign~~ feat: [RFC] Rewrite for Monaco, Context and the beginnings of the Redesign May 11, 2020

acao force-pushed the feat/use-context-hooks branch 2 times, most recently from b384999 to 87a5570 Compare May 11, 2020 22:35

feat: editor tabs by @harshithpabbati, doc explorer as plugin

9fd2682

Co-Authored By: Harshith Pabbati <[email protected]>

acao force-pushed the feat/use-context-hooks branch from 87a5570 to 9fd2682 Compare May 11, 2020 23:29

acao mentioned this pull request May 12, 2020

feat: monaco-graphql docs, api, improvements #1521

Merged

fix: get deploy preview working, fix types

2b8ff67

acao changed the title ~~feat: [RFC] Rewrite for Monaco, Context and the beginnings of the Redesign~~ feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign May 13, 2020

acao changed the title ~~feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign~~ feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign May 13, 2020

acao mentioned this pull request May 13, 2020

feat: [RFC] GraphiQL rewrite for monaco editor, react context and redesign, i18n #1523

Merged

acao closed this May 13, 2020

snyk-bot mentioned this pull request Sep 16, 2021

[Snyk] Security upgrade yargs from 7.1.2 to 15.0.1 saurabharch/graphiql#20

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign#1468

feat: [RFC] Rewrite for monaco editor, react context and the beginnings of the redesign#1468
acao wants to merge 45 commits intographql:masterfrom
acao:feat/use-context-hooks

acao commented Apr 6, 2020 •

edited

Loading

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

acao commented May 7, 2020 •

edited

Loading

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

acao commented May 8, 2020

Uh oh!

acao commented May 9, 2020

Uh oh!

harshithpabbati commented May 9, 2020

Uh oh!

Uh oh!

acao commented May 11, 2020 •

edited

Loading

Uh oh!

harshithpabbati commented May 12, 2020 •

edited

Loading

Uh oh!

acao commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

acao commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

acao commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

harshithpabbati commented May 7, 2020

Uh oh!

acao commented May 8, 2020

Uh oh!

acao commented May 9, 2020

Uh oh!

harshithpabbati commented May 9, 2020

Uh oh!

Uh oh!

acao commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshithpabbati commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acao commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

acao commented Apr 6, 2020 •

edited

Loading

acao commented May 7, 2020 •

edited

Loading

acao commented May 11, 2020 •

edited

Loading

harshithpabbati commented May 12, 2020 •

edited

Loading