Skip to content

feat: Monaco Mode - Phase 2 - Mode & Worker#1459

Merged
acao merged 24 commits intographql:masterfrom
acao:feat/monaco-service
Apr 15, 2020
Merged

feat: Monaco Mode - Phase 2 - Mode & Worker#1459
acao merged 24 commits intographql:masterfrom
acao:feat/monaco-service

Conversation

@acao
Copy link
Copy Markdown
Member

@acao acao commented Apr 4, 2020 •
edited
Loading

For the second phase, we will implement a monaco mode and worker, and we only support completion and maybe diagnostics. Summarized more completely in #1445

Outcomes

  • introduces packages/monaco-graphql and examples/monaco-webpack
  • Diagnostics (working), Completion Support (todo)
  • Required baseline: schema loading, primitive config loading

Todo

  • GraphQL Mode & contribution
  • GraphQL Worker Manager
  • GraphQL Worker - written but worker manager will not load it
  • GraphQL Language features
    • completion - mode providers work
    • Diagnostics - mode providers work

Another PR?

  • Create graphql-config loaders for browser config load by default
  • programatically provide graphql-config ala Programatic graphql config #1272?
  • handle schema loading/changing schema via monaco service

Scoped to only completion for now. Other features will be iterative

How to Develop/Test

  1. check out this branch
  2. from the root: yarn --force
  3. from the root: (watcher) yarn tsc --watch (one time) yarn build-ts
  4. in another terminal tab, from examples/monaco-graphql: yarn start

This was referenced Apr 4, 2020
Closed
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2020 •
edited
Loading

Codecov Report

Merging #1459 into master will decrease coverage by 0.17%.
The diff coverage is 45.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
- Coverage   58.98%   58.80%   -0.18%     
==========================================
  Files          60       60              
  Lines        3023     3042      +19     
  Branches      796      811      +15     
==========================================
+ Hits         1783     1789       +6     
- Misses       1194     1207      +13     
  Partials       46       46
Impacted Files Coverage Δ
packages/graphiql/src/components/QueryHistory.tsx 69.23% <ø> (ø)
packages/graphiql/src/components/ResultViewer.tsx 73.80% <ø> (ø)
...hql-language-service-interface/src/GraphQLCache.ts 51.45% <0.00%> (ø)
...-language-service-interface/src/findGraphQLTags.ts 64.86% <ø> (ø)
...ql-language-service-interface/src/parseDocument.ts 87.50% <ø> (ø)
...hql-language-service-interface/src/stringToHash.ts 0.00% <ø> (ø)
...hql-language-service-parser/src/CharacterStream.ts 68.75% <ø> (ø)
...kages/graphql-language-service-parser/src/Rules.ts 63.04% <ø> (ø)
...raphql-language-service-parser/src/onlineParser.ts 82.20% <ø> (ø)
...ql-language-service-server/src/MessageProcessor.ts 57.40% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddc11d...8722551. Read the comment docs.

@acao acao mentioned this pull request Apr 5, 2020
Open
9 tasks
@acao acao changed the base branch from master to feat/pre-monaco-lsp April 5, 2020 18:41
@acao acao force-pushed the feat/monaco-service branch from 5f2e990 to ae29b0a Compare April 5, 2020 19:03
@acao acao force-pushed the feat/pre-monaco-lsp branch 4 times, most recently from 87bd8b2 to f3a69f2 Compare April 6, 2020 00:58
@acao acao force-pushed the feat/monaco-service branch 4 times, most recently from a8e5f1e to 9ef2d47 Compare April 9, 2020 00:51
acao
acao commented Apr 9, 2020
View reviewed changes
Comment thread packages/monaco-graphql/package.json
"typings": "dist/monaco.contribution.d.ts",
"contributors": [
{
"name": "Peng Lyu",
Copy link
Copy Markdown
Member Author

@acao acao Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebornix gave you credit since you created most of the features! haha

@acao acao force-pushed the feat/monaco-service branch from f692a1c to 5654c58 Compare April 9, 2020 16:14
This was linked to issues Apr 10, 2020
Create a useable GraphQL Monaco Mode and Example #1445
Closed
GraphiQL 2.0.0 beta Roadmap (monaco, redesign and plugin API!) #1446
Closed
@acao acao changed the base branch from feat/pre-monaco-lsp to master April 11, 2020 17:53
@acao acao force-pushed the feat/monaco-service branch from c9bbac2 to 62a22b4 Compare April 12, 2020 15:54
@acao
Copy link
Copy Markdown
Member Author

acao commented Apr 12, 2020

to preview the monaco branch, append the slash /monaco path:
https://deploy-preview-1459--graphiql-test.netlify.com/monaco/

@acao acao force-pushed the feat/monaco-service branch 3 times, most recently from 2eef81c to 7b6a91b Compare April 14, 2020 00:45
@acao acao force-pushed the feat/monaco-service branch 5 times, most recently from d1b1cc4 to 279c327 Compare April 15, 2020 03:48
acao
acao commented Apr 15, 2020
View reviewed changes
Comment thread packages/monaco-graphql/package.json
{
"name": "monaco-graphql",
"description": "full service, official monaco mode for GraphQL",
"version": "2.3.4-alpha.5",
Copy link
Copy Markdown
Member Author

@acao acao Apr 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can decide what this should be before we release a stable version, but I'll probably just change it to something like 0.1.0 for the first pre-release

@acao acao force-pushed the feat/monaco-service branch from 279c327 to 10525dc Compare April 15, 2020 04:16
@acao acao force-pushed the feat/monaco-service branch from 10525dc to 8722551 Compare April 15, 2020 04:29
@acao acao changed the title Monaco Mode - Phase 2 - Mode & Worker feat: Monaco Mode - Phase 2 - Mode & Worker Apr 15, 2020
@acao acao merged commit bc95fb4 into graphql:master Apr 15, 2020
@acao acao deleted the feat/monaco-service branch April 15, 2020 04:50
@acao acao linked an issue May 17, 2020 that may be closed by this pull request
Proposal: More LSP friendly package names #1404
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

monaco-graphql

Projects

None yet

Milestone

[email protected]

2 participants

@acao @rebornix