Skip to content

Monaco Mode - Phase 1#1421

Closed
acao wants to merge 13 commits intomasterfrom
feat/monaco-service
Closed

Monaco Mode - Phase 1#1421
acao wants to merge 13 commits intomasterfrom
feat/monaco-service

Conversation

@acao
Copy link
Copy Markdown
Member

@acao acao commented Mar 13, 2020 •
edited
Loading

For the first phase, we will only support completion and maybe diagnostics. Summarized more completely in #1445

Note: I will be pulling all the LSP changes out of this PR and creating seperate PRs to introduce those, so that this PR will soon be ~20 new files, a few changes and thats it, ideally.

Everything that isn't complete is partially underway. The only issue now is that monaco can't find the AMD id of our custom language worker.

Outcomes

  • introduces packages/monaco-graphql and examples/monaco-webpack
  • Diagnostics (working), Completion Support (todo)
  • Required baseline: schema loading, primitive config loading

Todo

  • GraphQL Mode & contribution
  • GraphQL Worker Manager
  • GraphQL Worker - written but worker manager will not load it
  • GraphQL Language features
    • completion - mode providers work, worker doesnt
    • Diagnostics - mode providers work, worker doesnt
  • Create graphql-config loaders for browser config load by default
  • programatically provide graphql-config ala Programatic graphql config #1272?
  • handle schema loading/changing schema via monaco service

Scoped to only completion for now. Other features will be iterative

How to Develop/Test

  1. check out this branch
  2. from the root: yarn --force
  3. from the root: (watcher) yarn tsc --watch (one time) yarn build-ts
  4. in another terminal tab, from examples/monaco-graphql: yarn start

@acao acao mentioned this pull request Mar 13, 2020
Open
9 tasks
@acao acao force-pushed the feat/monaco-service branch from a0a0f46 to e0291d3 Compare March 14, 2020 16:35
@rebornix rebornix mentioned this pull request Mar 15, 2020
Merged
@acao acao changed the title Monaco Service Monaco Plugin Mar 18, 2020
@acao acao force-pushed the feat/monaco-service branch from aa536aa to 38a1cf1 Compare March 23, 2020 19:44
@acao acao closed this Mar 23, 2020
@acao acao reopened this Mar 23, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #1421 into master will decrease coverage by 1.10%.
The diff coverage is 20.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   58.98%   57.87%   -1.11%     
==========================================
  Files          60       63       +3     
  Lines        3023     3091      +68     
  Branches      806      819      +13     
==========================================
+ Hits         1783     1789       +6     
- Misses       1194     1256      +62     
  Partials       46       46
Impacted Files Coverage Δ
packages/graphiql/src/components/QueryHistory.tsx 69.23% <ø> (ø)
packages/graphiql/src/components/ResultViewer.tsx 73.80% <ø> (ø)
...hql-language-service-interface/src/GraphQLCache.ts 51.45% <0.00%> (ø)
...-language-service-interface/src/findGraphQLTags.ts 64.86% <ø> (ø)
...ql-language-service-interface/src/parseDocument.ts 87.50% <ø> (ø)
...hql-language-service-interface/src/stringToHash.ts 0.00% <ø> (ø)
...hql-language-service-parser/src/CharacterStream.ts 68.75% <ø> (ø)
...kages/graphql-language-service-parser/src/Rules.ts 63.04% <ø> (ø)
...raphql-language-service-parser/src/onlineParser.ts 82.20% <ø> (ø)
...ql-language-service-server/src/MessageProcessor.ts 57.40% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fdab8c...de3f8ce. Read the comment docs.

@acao acao changed the title Monaco Plugin Monaco Plugin - Phase 1 Mar 23, 2020
@acao acao force-pushed the feat/monaco-service branch 3 times, most recently from a64fed1 to 3ec78fb Compare March 26, 2020 00:06
@acao acao changed the title Monaco Plugin - Phase 1 Monaco Mode - Phase 1 Mar 30, 2020
@acao acao force-pushed the feat/monaco-service branch from b1b3544 to d1bb9d1 Compare March 31, 2020 19:35
@acao acao added rfc Request for Comment work-in-progress not ready to merge yet, PR is available for demonstration/review purposes labels Apr 1, 2020
@acao acao mentioned this pull request Apr 1, 2020
Closed
7 tasks
@acao acao added this to the [email protected] milestone Apr 1, 2020
@acao acao force-pushed the feat/monaco-service branch from d1bb9d1 to 0d0f6b5 Compare April 4, 2020 18:27
@acao acao force-pushed the feat/monaco-service branch from 0d0f6b5 to de3f8ce Compare April 4, 2020 18:28
@acao
Copy link
Copy Markdown
Member Author

acao commented Apr 4, 2020

closed for #1459

@acao acao closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rfc Request for Comment work-in-progress not ready to merge yet, PR is available for demonstration/review purposes

Projects

None yet

Milestone

[email protected]

Development

Successfully merging this pull request may close these issues.

2 participants

@acao @rebornix