[new-ui] Panels & themes#1157
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 48.68% 48.68%
=======================================
Files 64 64
Lines 3003 3003
Branches 650 650
=======================================
Hits 1462 1462
Misses 1306 1306
Partials 235 235Continue to review full report at Codecov.
|
|
@walaura thanks a bunch, this is looking so splendid! giving me all kinds of ideas for the frontbackend side of things, seeing things come to fruition on this side |
|
yas!!! so excited to hear |
| ); | ||
| }; | ||
|
|
||
| Layout.propTypes = LAYOUT_PROP_TYPES; |
There was a problem hiding this comment.
this makes perfect sense for now, but as you may know we are converting to typescript within a month ish by very popular demand. once we get some architectural changes implemented
There was a problem hiding this comment.
omg honestly can't wait!! i feel a bit like freefalling in here not having typechecking. Can I use TS on this part already?
|
looks good to merge! whatchu think @walaura |
3 participants
Thinking out loud and writing docs about how to do themability here, comments welcome!
I also added new components for flex layouts (super exciting) and pink titles (actually exciting)
And made it so storybook automatically generates jest snaps, this seems pretty sensible because they are basically the same thing.