Add Graphframe Type Degree Methods #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joelrobin18 <[email protected]>
Signed-off-by: joelrobin18 <[email protected]>
Signed-off-by: joelrobin18 <[email protected]>
SemyonSinchenko
approved these changes
Oct 22, 2025
Collaborator
SemyonSinchenko
left a comment
SemyonSinchenko
left a comment
There was a problem hiding this comment.
LGTM overall, thanks for the contribution @joelrobin18 !
Please, address pythoncode style issues.
Related to:
[error] /home/runner/work/graphframes/graphframes/core/src/main/scala/org/graphframes/GraphFrame.scala:338:36: Passing an explicit array value to a Scala varargs method is deprecated (since 2.13.0) and will result in a defensive copy; Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
We cannot drop 2.12 now because we should support 3.5.x branch. Can you add a @nowarn?
Thanks!
Signed-off-by: joelrobin18 <[email protected]>
joelrobin18
force-pushed
the
feat/graphframe-type-degree-method
branch
from
f8195b0 to
638c549
Compare
SemyonSinchenko
approved these changes
Oct 23, 2025
Collaborator
|
Thanks for the contribution @joelrobin18 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implementation of Type Degree methods such as typeDegree, typeInDegree, TypeOutDegree
Why are the changes needed?
Fix #519