bug: prevent negated bidirectional edge #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goungoun
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 86.60% 84.71% -1.89%
==========================================
Files 63 63
Lines 2881 2983 +102
Branches 321 350 +29
==========================================
+ Hits 2495 2527 +32
- Misses 386 456 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
goungoun
changed the title
Contributor
Author
|
@SemyonSinchenko, thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR ensures that a negated bidirectional edge
!(u)<-[]->(v)is not supported. It includes the parse exception handling and documentation.Why are the changes needed?
The existing code converts the bidirectional motif pattern
!(u)<-[]->(v)to!(u)-[]->(v);(v)-[]->(u)which is wrong.