Skip to content

Conversation

@SemyonSinchenko
Copy link
Collaborator

What changes were proposed in this pull request?

SP can handle both directed and undirected edges.

Tests:

  • on scala side (LDBCSuite)
  • on python side

Why are the changes needed?

Close #736

@SemyonSinchenko SemyonSinchenko self-assigned this Oct 17, 2025
@SemyonSinchenko SemyonSinchenko added scala pyspark-classic GraphFrames on PySpark Classic pyspark-connect GraphFrames on PySpark Connect graphx Anything related to GraphX labels Oct 17, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.23%. Comparing base (7c82387) to head (e7794e1).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...park/sql/graphframes/GraphFramesConnectUtils.scala 0.00% 4 Missing ⚠️
core/src/main/scala/org/graphframes/mixins.scala 66.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   84.32%   84.23%   -0.09%     
==========================================
  Files          63       65       +2     
  Lines        3030     3147     +117     
  Branches      350      370      +20     
==========================================
+ Hits         2555     2651      +96     
- Misses        475      496      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SemyonSinchenko SemyonSinchenko merged commit ef06414 into graphframes:main Oct 27, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 736-directed-sp branch October 27, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphx Anything related to GraphX pyspark-classic GraphFrames on PySpark Classic pyspark-connect GraphFrames on PySpark Connect scala

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: handle direction in ShortestPath

3 participants